Sign in to follow this  
odinalf

Skills not fully showing

Recommended Posts

[13:35:43] Body increased by 0.000 to 58.434 is a curious tick that doesnt seem to be affecting just me and seems harmless. Skilltracker is still lighting up when a tick is gained.

 

Edit: my ticks are set to all so it should show [13:35:43] Body increased by 0.000??? to 58.434???.

Edited by odinalf
further information

Share this post


Link to post
Share on other sites

I'm seeing the same thing with many skills, even though my client is set to show 'always'.  Sometimes the skill gives me 6 decimal places and other times the same skill shows .000 with 3 decimal places.  I've added this to the bug list.  Thanks for your report as well.

  • Like 2

Share this post


Link to post
Share on other sites

adding this [05:59:37] Mining increased by 0,002 to 83,618   on silver vein i did 0,02+ or something, its way off chart

not a clue whats wrong in code

Share this post


Link to post
Share on other sites

I'm also seeing this as well as some odd rounding...

[22:20:39] Smithing increased by 0.000 to 95.999

[22:20:58] Smithing increased by 0.000046 to 95.998848

[22:21:06] Smithing increased by 0.000061 to 95.998909

Share this post


Link to post
Share on other sites

Ahh I know what this is, I actually fixed another bug in there recently. And that allowed this one to show it's ugly face.

It should only affect those of you using the always option, and only when the skill tick is > 0.0001
Previously it would throw a silent error when it happened, I fixed that in a quick drive by (was working on other things when I spotted it). 

A few quick snippets to show how small error it was :)
 

The original error:

if (delta > 1E-4)
{
	change = String.format("%.3g", Float.valueOf(delta));
  	skillprec = change.length() - 3;
}


The quick drive by fix:
 

if (delta > 1E-4)
{
	change = String.format("%.3f", Float.valueOf(delta));
	skillprec = change.length() - 3;
}

And what I hope will be the final one (worked after testing):

if (delta > 1E-4)
{
	change = String.format("%.4f", Float.valueOf(delta));
	skillprec = 4;
}

 

Such small things, hard to spot when you are not actively looking for them.

 

Next client update should include the fix.

  • Like 4

Share this post


Link to post
Share on other sites

latest update like halfway fixed this. still not showing smallest tick size if i have always turned on.

 

[11:50:32] Meditating increased by 0.0012 to 

Share this post


Link to post
Share on other sites

maybe it needs to be

change = String.format("%.8f", Float.valueOf(delta));
	skillprec = 8;

for "allways"

(i am not a coder, i am just guessing)

Share this post


Link to post
Share on other sites

Erik indicated above that it would be fixed next client update.  I think today's update was server only?

 

Edit:  I've been informed client updated as well.  I'll relog this.  Thanks.

Edited by Alectrys
corrected info

Share this post


Link to post
Share on other sites

Well it was fixed with the codes original intent for values > 0.0001, I am guessing here that who ever wrote that code originally figured that it would be less readable if it showed all the decimals for larger values. 
As for changing it to 8, the rest of the always option only show 6.

A value of 8 would result in the skill log printing things like: 1E-7.

 

If you rather have all values with 6 that can easily be arranged, not so much of adding code as removing it, and quite frankly just make the code more readable, so I'm in favor of it :D


 

  • Like 1

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Sign in to follow this