Range pole QL doesn't matter as intended (fix included)

[Ostentatio 1,970]

Intended behavior: Range pole QL limits range of survey/bridge-planning the same way dioptra QL does.

 

Actual behavior: Range pole QL matters for surveying, but not bridge-planning. You can plan a bridge with any range pole as long as other factors (skill, dioptra QL) are OK.

 

Cause (in CreatureBehavior.PlanBridge()):

final Item item = this.subjectItemOrNull(target);
float maxPoleTiles = 0.0f;
float poleQL = 0.0f;
if (item != null) {
  poleQL = item.getQualityLevel();
  maxPoleTiles = this.maxTilesFor(source);
}

"source" here is a typo, and should be "item" ("source" refers to the dioptra in this context, "item" refers to the target, which is the pole).

 

Fix: Change "source" here to "item" in this code snippet.

[Dairuka 888]

Visual aid:

Spoiler

 

Spoiler

http://i.imgur.com/CxWRO3M.jpg

 

[Drused 18]

I can confirm that with a QL 14 range pole, you can build length 11 and 14 bridges at a minimum.  We have done so many times over the past few weeks.

 

[Nicrolis 980]

can you check into diaoptras as well? Ive been using a 30ql for doing around 9-10  lengths

[Ostentatio 1,970]

1 hour ago, Nicrolis said:

can you check into diaoptras as well? Ive been using a 30ql for doing around 9-10  lengths

 

30QL should be able to do up to approximately 12 tiles. The formula is QL*0.4 in tiles for each tool, but between that and the exact positions of the characters possibly mattering, there's probably a few steps of rounding involved, so I'd try to shoot for slightly higher QL tools than needed.

[Tich 1,389]

Thanks.

Fixed for next update.