• Content Count

  • Joined

  • Last visited

Everything posted by Mthec

  1. Weird. I'm thinking then, that it doesn't have anything to do with CustomTrader. The reason it's appearing in the logs is because the problem is happening at some point when the creatures are polled and CustomTrader hooks into that. But it shouldn't actually do anything except to CustomTraders. Sorry I cannot be of further help. If you get any different messages, let me know.
  2. Strange, it really looks like it is missing something from the end. So much for that idea then. When does this error happen, is it when a player performs some kind of action (like adding an item to the list, or when trading), or does it show up on it's own (possibly every few seconds)?
  3. As it is I cannot see what the problem could be. There should be some more to the error message, if you could post more I will take a look.
  4. CustomTrader update Download Fixed creating custom traders using Summon. Added weight option for trader items. Important - This update will not work with the previous database, so you should dismiss any already created custom traders and then delete customtrader.db in the individual servers sqlite folder (e.g. WurmServerLauncher/Creative/sqlite). Sorry about this, whilst I could have worked around it, as the mod is still so new I thought it best to keep things clean rather than leaving code to update old databases. I should have thought about it, but since I don't run a server I can miss things like that. Also, added the weight option, it didn't take long. Thank you for the suggestion.
  5. There shouldn't be any default items. Did you create the custom trader with the Place Npc>Custom Trader menu, or by using summon? Because I just tried summon (I hadn't been using that) and it came with the default trader items, whereas the other way removes them. For the moment, you can just use Manage and tick the "Remove all items from inventory?" option after creation. I shall have a look into removing the items another way.
  6. Sorry about that, Dropbox links being funny again where it appears on my end. Fixed.
  7. New Mod Beta Release Custom Trader Download A new type of NPC based on the standard trader, that can only be placed by GMs. Has various options for a custom inventory, including restocking rules. Use a 'tag' to share the same inventory between multiple custom traders, or just use a unique inventory. Placing a Custom Trader As a GM, activate your wand and right-click on the tile you wish the trader to appear. Choose Place Npc>Custom Trader. A menu will pop-up offering three settings, name, tag and gender. Leave the tag blank if you wish them to only supply the items you specifically set for that custom trader. Setting up stock With a wand, right-click on the custom trader and select Manage. In the first window you can change the tag of the custom trader, as well as empty their inventory and restock them to full capacity. Item List is where you add/remove items. Adding an item is very similar to BuyerMerchant, with the addition of specifying enchantments, and restocking rules. Restocking Rules: Rate How many items are added each interval, up to the maximum. 0 restocks to the maximum every time. Interval How often the trader should be restocked, in hours. 0 restocks the custom trader after each sale. Stock The maximum number of this item to be available on the trader at any one time. Some possible uses: A replacement for the normal trader, with fewer or more items available. A starter trader, offering some basic supplies for new players. A mine "foreman". Add a small amount of ore on a regular basis to simulate a public mine. Think it is about feature complete. Don't want to overcomplicate things. Would like some feedback on the text in the menus, is there anything that needs clarifying, etc. I've set the range of items that can be used very wide, similar to BuyerMerchant. Quite a few items will not be ones you want to offer, but I thought it best to be flexible for any custom server setups. I've mainly been testing on the beta version of Wurm Unlimited, however it seems to work on the non-beta. Screeenshots:
  8. Crafter fix Download Fixed potential issue with workbooks being invalid/not being found and causing NullPointerException. Not doing very well, am I? I've dealt with the error itself, but it is likely caused by a problem with one of the crafters workbooks being missing, or not being valid. I've added a couple more error messages that should clear things up, or maybe I'm wrong and it'll all be fine now. Let me know if you get any more problems.
  9. You set the values in in your mod folder. It should look like this. No, these settings apply to all buyers. I could look into it, but am currently working on another mod and don't have much spare time. Sorry.
  10. Crafter Fix Download Fix for error when removing Job. Not sure what the original cause of this was. Trading multiple times seems to run okay on my end, and I'm not sure why it would affect all crafters. However there was definitely a problem, which I've now fixed. See if that clears things up, if not let me know and I'll keep looking.
  11. If you're sure, that shouldn't be too difficult. Firstly, prices are defined in BuyerHandler.getTraderBuyPriceForItem. If you want to add any item exceptions you can do it here (e.g. you only want to accept gems), and then just call the parent method. So something like: @Override public int getTraderBuyPriceForItem(Item item) { PriceList.Entry entry = priceList.getEntryFor(item); if (entry == null) super.getTraderBuyPriceForItem(item); return getTraderBuyPriceForItem(entry, item); } Which will also handle all the local buy price stuff I have never really looked into. The other part you'll need to change is in suckInterestingItems, which decides what items traders will accept, and for Buyers ignores anything not on their PriceList. Starting here. Then you'll need to extract, or copy, this section to add the items to the trade. The stuff inbetween only relates to PriceLists. I think that should be it, just let me know if you have any problems.
  12. BuyerMerchant fix Download Fixed apply_max_to_merchants was not being applied when destroy_bought_items was also true. I think I may have found the issue, do you also have destroy_bought_items set to true? If so, then the above fix should sort things out. Otherwise, sorry, I was looking at the output rather than the server.log. In my server.log I get: [03:42:45 PM] INFO com.wurmonline.server.steam.SteamHandler: Starting the server *** [03:42:47 PM] INFO com.wurmonline.server.steam.SteamHandler: Server connected to steam With the *** being any number of lines depending on how many mods you have that put messages here. Although I think the "Server connected to steam" line can vary in timing, so it may appear in the middle. In there, you should find a line like: [03:42:46 PM] INFO mod.wurmunlimited.buyermerchant.BuyerMerchant: Buyer and merchant max items set to 200
  13. That is how it should work. In the logs, just after the server is up and running (between "Starting the server" and "Wurm Server launcher finished at..."), you should get a line saying "Buyer and merchant max items set to <your max setting>". The only limitations are: Players can only carry 100 items (GMs are not limited), so they can't receive in trade more than 100 minus the number of currently carried items. You can only drag 100 items between windows at a time. Since items don't leave your inventory until the trade is complete, you will need to select the lower items separately when dragging. i.e. You can't just drag across a stack as it will only drag the first 100 items. Anything else, just let me know what message you are getting and I'll take another look.
  14. Crafter update/fix Download Metal lumps of special types were becoming bugged when they were low weight. Missed Hire question in previous fix. Added remove_donations_at option to .properties. Set to a whole number (positive, zero or negative) to have crafters destroy donation items when the item reaches the ql plus the value relative to their current skill (Default disabled). For example, at a value of 10, items will be destroyed when their ql reaches 10 or more ql above the crafters skill for that item. e.g. With 30 skill in Blacksmithing, a shovel will be destroy when the ql is greater than: 10 - 40ql -10 - 20ql 0 - 30ql Fixed. This was caused by special metal lumps having a low default weight, so that larger items consume the entire lump. I was so certain I'd sorted that out, but it must have been for something else. Shouldn't require any extra work on your part. Whoops, I missed the Hire question in the previous update. I've added a new option that should help with this.
  15. Crafter update/fix Download Added a new window only accessible to GM (specifically power 2+) characters that allows setting the skills of Crafters directly. Donations should now be improved in the proper order. Some miscellaneous changes. This is more of a difference between how I started the mod (for players) and how it's developed with feedback (also GM controlled). So what I have done is, firstly, made it so that GM characters can always set the Skill Cap of their controlled Crafters (subject to starting_skill and max_skill in .properties, commenting them out sets them to defaults (20 and 99.99999)). I've also added a second screen, that will not be available to normal players, called "Set Skill Levels", which lets GMs set the skill levels directly. e.g. You could set Blacksmithing to 50 and Jewellery to 30, when using can_learn=false, and customers will only be able to select improvement for items up to that level. The message was a bug. This one sort of comes down to laziness on my part. When setting up donation items I didn't want to accidentally throw an item away just because it had reached its cap for the time being. I've changed it now so that it will always work in order of lowest to highest ql. Sorry about that. I haven't had much time for modding lately, but this is a suggestion I was given a long time ago (and felt I didn't know enough at the time) and has also been recently requested. So I've started working on it now. It shouldn't be too difficult, but due to time constraints it might be a while before it's ready. It also depends how many more bugs people find in my current mods... Apologies for taking a year to reply.
  16. Crafter fix Download Hopefully fixed the issue with items being mailed repeatedly or being available for pick-up after having being retrieved the item from the mail. Fixed several other bits and pieces I discovered along the way. Also, I have changed the way money is handed out to Crafters. Before the value on the Management screen would be inaccurate, now money is only given out on completed orders. Note: Some money may be lost on pre-update orders. Sorry about that. Apologies for the late reply, thought it would be dealt with sooner so I left off posting. I couldn't reproduce the multiple mail issue, however I have experienced it in the past (and thought it was fixed). But I did find another issue that was causing similar problems and have re-jiggled the system in a way that should fix all problems of that type. Let me know if things still aren't right on your end. DeliveryContracts fix Download Fixed issue with dropping items. No idea why it was released that way, just my own stupidity. Just to let you know, I haven't missed this and will working on it next. Well that was easier than I thought it would be. Thank you for the kind words.
  17. Crafter update Download Added crafter_skill_gain_rate to .properties (default disabled). This overrides the server wide skill gain for Crafters if applied. Set 1 or comment out to use server skill gain value. Also removed the beta tag since everything seems to be going okay. I've added the option, let me know if it doesn't quite work right for you. The skill gain rate for Crafters isn't really set anywhere, it just uses the built-in skill system. Depending on how your system is applied I would have thought it would still work for Crafters. The one possibility I can think of is if your system applies to Players, as Crafters are technically Creatures, so some of the Player specific skill stuff (e.g. stamina affecting amount gained) does not apply.
  18. It should be following the server skill rate already. I could add a separate skill rate for Crafters if you want, there is just the question of would it be a multiplier on top of the server rate or override the server rate?
  19. Crafter and MerchantCap fix Crafter Download MerchantCap Download Fixed issue with one of my libraries being updated before the recent Crafter update. These should be the only mods that are affected, however you don't need to update MerchantCap unless you also want to use Crafter. Sorry about that. I updated one of my libraries a while back, but since I have all of my mods installed it hid the problem on my end. All should be good now.
  20. Mini Crafter Update Download Added moon_metal modifier. Default is 1.0 to keep it in-line with past behaviour. The modifier is applied on top of the base_price modifier, like dragon_armour. To be explicit, moon_metal consists of adamantine, glimmersteel and seryll.
  21. [FINAL] Upkeep Costs

    That's what it is supposed to do. It seems to be working fine on my end so I am not sure what the problem is. When the deed owners check their upkeep does it show the correct cost per month, or is that wrong too?
  22. [FINAL] Upkeep Costs

    Fix Download Fixed use_per_server_settings option. So sorry@Batta, I must have broke it when I was cleaning things up. Thank you for your continued feedback.
  23. [FINAL] Upkeep Costs

    Update Download Added use_per_server_settings to the .properties file. If true it will use a .properties file in the individual server folders, if false it will only use the main mod file. Default is true, to keep it in-line with previous behaviour. Changing the value will not delete the old per server files, so you can switch back and forth at will. Also took the time to refresh the mod a little. It was one of my first and I've learnt a lot since then. May have found (and fixed) a bug with disband warnings along the way.
  24. Hmm, strange that you would be getting that error without having placed a crafter. What it is saying is that it has found a creature that it thinks is a Crafter, but can't find it's workbook. Further up in the logs, during server load, there should be a line that says "No workbook found on creature (<creature-id>)". If you don't mind, could you use a GM character to find out what creature it is? In-game you can use the GM wand, right click on an item and select Creatures>GM interface, scroll down to GM Tool and type the id in, then click send. You could also look in the creatures database if you know how to do it. If you're not comfortable doing that, I can look in to writing up a workaround. Some quick possibilities off the top of my head, it is a Crafter (in which case deleting the creature is the easiest solution), some kind of problem with the mod id database (maybe a removed mod), some other mod conflict involving creatures, or I've missed something.
  25. [FINAL] Upkeep Costs

    The reason the order is all jumbled is because the file was generated by the mod, and the only way I found to make it preserve order seemed a bit involved at the time. But it doesn't actually matter which order the entries are in, so you can copy and paste as you like. The only important bit is the "classname" and "classpath", they must be in the main .properties file for ago's modlauncher to find the mod. It wouldn't matter if they were copied into the per server file though, they would be ignored.